excel - VBA - Replacing a string in text file with a variable value from other file -


i'm new vba , stuck @ 1 point of code. appreciate if .

question: have excel file 2 columns, need search strings 1 one first column , if there match in other file, xml file, need replace string corresponding string in second column.

problem: wrote below code , working fine me hard-coded value, when try replace using variables, run's doesn't anything. changed code one. but, error.

can me ?

here code : (which working hard-coded value) 

 private sub commandbutton1_click()     call exlfileread  end sub  sub exlfileread()     dim exlfile string     dim oldvalue string     dim newvalue string     dim x long     dim countrow long     dim y long     dim z long      y = 1     z = 2      exlfile = application.getopenfilename()`      workbooks.open (exlfile)`      open exlfile input #1     activesheet          countrow = .cells(.rows.count, "a").end(xlup).row     end     x = 1 countrow         call xmlfile(activesheet.cells(x, y).value, activesheet.cells(x, z).value)     next x      close     end sub      sub xmlfile(rowoldvalue string, rownewvalue string)     const forreading = 1, forwriting = 2      dim fso, filein, fileout     dim strtmp      set fso = createobject("scripting.filesystemobject")     set filein = fso.opentextfile("c:\users\ashisha\desktop\exp\note.xml", forreading)     set fileout = fso.opentextfile("c:\users\ashisha\desktop\exp\note1.xml", forwriting, true)      until filein.atendofstream        strtmp = filein.readline                 if len(strtmp) > 0                    if instr(1, strtmp, rowoldvalue, vbtextcompare) = 0                       strrep = replace(strtmp, "abcd", "new text")                       fileout.writeline strrep                    end if                  end if     loop      filein.close     fileout.close      end sub enter code here ---------------------------------------------------------------------- -----this 1 executing, not replacing----------- -----i have old value in rowoldvalue , value be----------    -------------------replaced in rownewvalue---------------------------- **********************************************************************   private sub commandbutton1_click()     call exlfileread  end sub  sub exlfileread()     dim exlfile string     dim oldvalue string     dim newvalue string     dim x long     dim countrow long     dim y long     dim z long      y = 1     z = 2      exlfile = application.getopenfilename()`      workbooks.open (exlfile)`      open exlfile input #1     activesheet          countrow = .cells(.rows.count, "a").end(xlup).row     end     x = 1 countrow         call xmlfile(activesheet.cells(x, y).value, activesheet.cells(x, z).value)     next x      close     end sub      sub xmlfile(rowoldvalue string, rownewvalue string)     const forreading = 1, forwriting = 2      dim fso, filein, fileout     dim strtmp      set fso = createobject("scripting.filesystemobject")     set filein = fso.opentextfile("c:\users\ashisha\desktop\exp\note.xml", forreading)     set fileout = fso.opentextfile("c:\users\ashisha\desktop\exp\note1.xml", forwriting, true)      until filein.atendofstream        strtmp = filein.readline                 if len(strtmp) > 0                    if instr(1, strtmp, rowoldvalue, vbtextcompare) = 0                       strrep = replace(strtmp, rowoldvalue, rownewvalue)                       fileout.writeline strrep                    end if                  end if     loop      filein.close     fileout.close      end subi'm new vba , stuck @ 1 point of code. appreciate if .

question: have excel file 2 columns, need search strings 1 one first column , if there match in other file, xml file, need replace string corresponding string in second column.

problem: wrote below code , working fine me hard-coded value, when try replace using variables, run's doesn't anything. changed code one. but, error.

can me ?

here code : (which working hard-coded value) 

 private sub commandbutton1_click()     call exlfileread  end sub  sub exlfileread()     dim exlfile string     dim oldvalue string     dim newvalue string     dim x long     dim countrow long     dim y long     dim z long      y = 1     z = 2      exlfile = application.getopenfilename()`      workbooks.open (exlfile)`      open exlfile input #1     activesheet          countrow = .cells(.rows.count, "a").end(xlup).row     end     x = 1 countrow         call xmlfile(activesheet.cells(x, y).value, activesheet.cells(x, z).value)     next x      close     end sub      sub xmlfile(rowoldvalue string, rownewvalue string)     const forreading = 1, forwriting = 2      dim fso, filein, fileout     dim strtmp      set fso = createobject("scripting.filesystemobject")     set filein = fso.opentextfile("c:\users\ashisha\desktop\exp\note.xml", forreading)     set fileout = fso.opentextfile("c:\users\ashisha\desktop\exp\note1.xml", forwriting, true)      until filein.atendofstream        strtmp = filein.readline                 if len(strtmp) > 0                    if instr(1, strtmp, rowoldvalue, vbtextcompare) = 0                       strrep = replace(strtmp, "abcd", "new text")                       fileout.writeline strrep                    end if                  end if     loop      filein.close     fileout.close      end sub


Comments

Post a Comment

Popular posts from this blog

Sort a complex associative array in PHP -

this question has answer here: php sort array subarray value 5 answers i have associative array in php like: $newarray1 = array ( [producta] => array ( [link] => http://sanjosespartan.com/blog/products/agile-java-development/ [visitcount] => 4 ) [productd] => array ( [link] => http://sanjosespartan.com/blog/products/intro-to-go/ [visitcount] => 1 ) [productg] => array ( [link] => http://sanjosespartan.com/blog/products/node-js-for-developers/ [visitcount] => 1 ) [productb] => array ( [link] => http://sanjosespartan.com/blog/products/beginning-mysql/ [visitcount] => 1 ) [productc] => array ( [link] => http://sanjosespartan.com/blog/products/computer-networks/ [visitcount] => 1 ) ...
Read more

vb.net - How to ignore if a cell is empty nothing -

how use roscolor() ignore value (like empty cell) ? color row if value upper 5 when there nothing in cell, want ignore roscolor() apply, how? public sub roscolor() integer = 0 quotedatagridview1.rows.count() - 1 step +1 dim val integer val = quotedatagridview1.rows(i).cells(3).value if val = vbempty quotedatagridview1.rows(i).defaultcellstyle.backcolor = color.white elseif val < 5 quotedatagridview1.rows(i).defaultcellstyle.backcolor = color.red elseif val > 5 , val < 10 quotedatagridview1.rows(i).defaultcellstyle.backcolor = color.lightyellow end if next end sub you can check empty value following public sub roscolor() integer = 0 quotedatagridview1.rows.count() - 1 step +1 dim val = quotedatagridview1.rows(i).cells(3).value if isdbnull(val) or val nothing quotedatagridview1.rows(i).defaultcellstyle.backcolor = color.white ...
Read more

recursion - Can every recursive algorithm be improved with dynamic programming? -

i first year undergraduate csc student looking competitive programming. recursion involves defining , solving sub problems. understand, top down dynamic programming (dp) involves memoizing solutions sub problems reduce time complexity of algorithm. can top down dp used improve efficiency of every recursive algorithm overlapping sub problems? dp fail work , how can identify this? the short answer is: yes. however, there constraints. obvious 1 recursive calls must overlap. i.e. during execution of algorithm, recursive function must called multiple times same parameters. lets truncate recursion tree memoization. can use memoization reduce number of calls. however, reduction of calls comes price. need store results somewhere. next obvious constraint need have enough memory. comes not-so obvious constraint. memory access requires time. first need find result stored , maybe copy location. in cases, might faster let recursion calculate result instead of loading somewher...
Read more